[pull] master from mattermost:master - #921
Merged
Merged
Conversation
* [MM-57557] Remove dead Email login button color settings from the server EmailSettings.LoginButtonColor, LoginButtonBorderColor and LoginButtonTextColor were plumbed into the client config as EmailLoginButtonColor / EmailLoginButtonBorderColor / EmailLoginButtonTextColor, but no client — web or mobile — ever consumed them, so the email login button was never colored by these values. Remove the fields from the config struct and its defaults, drop the three client config props, and update the config fixtures that carried them. Also fixes MM-57556 and MM-57804, and follows the same removal already done for the AD/LDAP (MM-70140) and SAML (MM-70141) equivalents. * [MM-57557] Remove Email login button colors from the webapp and docs Drop the three Email Login Button Color settings from the Admin Console Experimental Features section along with their en.json strings, remove the matching ClientConfig and AdminConfig EmailSettings entries to stay in sync with the server model, and delete the corresponding documentation entries. The experimental settings doc's jq example referenced EmailSettings.LoginButtonColor, which no longer exists; point it at EmailSettings.EmailBatchingBufferSize instead.
* introduce mlogFieldNaming * apply vet-fix changes * Cover every keyed mlog constructor in the analyzer fixture * clarify end result in comment * Check mlog field keys on explicitly instantiated constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )